Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial crate #1

Merged
merged 21 commits into from
Jun 6, 2024
Merged

Add initial crate #1

merged 21 commits into from
Jun 6, 2024

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented May 28, 2024 •
edited
Loading

What

Add initial crate and npm package building, from:

Why

For exporting the XDR<>JSON functionality from the stellar-xdr Rust crate for use in the laboratory, and elsewhere.

@leighmcculloch @willemneal
Add initial crate
b67832e 
Co-authored-by: Willem Wyndham <willem@ahalabs.dev>
@leighmcculloch leighmcculloch mentioned this pull request May 28, 2024
Closed
@leighmcculloch leighmcculloch marked this pull request as ready for review June 4, 2024 05:34
willemneal
willemneal reviewed Jun 4, 2024
View reviewed changes
src/utils.rs Outdated Show resolved Hide resolved
@leighmcculloch
Copy link
Member Author

TODO:

  • Add basic tests.
    • Figure out how to use wasm-bindgen-test without needing to add rlib to the Cargo.toml that causes disables LTO and makes the wasm bigger
    • Get geckodriver working
    • Add a test for the types function
  • Update contributing docs to include what tools to install (wasm-pack, wasm-bindgen-cli, geckodriver), etc

willemneal
willemneal approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Glad we can final get something a least a little stable out of this.

@leighmcculloch leighmcculloch merged commit 1da1c12 into main Jun 6, 2024
6 checks passed
@leighmcculloch leighmcculloch deleted the go branch June 6, 2024 23:26
@leighmcculloch leighmcculloch mentioned this pull request Jun 7, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemneal willemneal willemneal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leighmcculloch @willemneal